issue-49 Changes wrt to Tags Block #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
jindaliiita
force-pushed
the
issue-41
branch
from
ce1e1f2 to
e2b482d
Compare
|
jindaliiita
requested review from
bosschaert,
sdmcraft,
dnbute,
RitwikSrivastava,
hparwani2 and
JiangLong2019
|
|
|
|
1 similar comment
|
@jindaliiita I can see a single tag repeated multiple times. Which is not the case on the sunstar.com page.
|
@RitwikSrivastava i have intentionally added random tags for my testing in draft document. |
sdmcraft
reviewed
Sep 22, 2023
| const tags = block.querySelectorAll('a'); | ||
| block.innerHTML = ''; | ||
|
|
||
| [...tags].forEach((tag) => { |
There was a problem hiding this comment.
We already have the tags in metadata block. Could we use them? One difference though is that you need links for them. But it looks like you can build it from the tag name itself. If not, we could keep it in a spreadsheet.
There was a problem hiding this comment.
Yes, i can check that. Good point
|
Tracked via #60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #49
Test URLs:
Before: https://main--sunstar--hlxsites.hlx.live/_drafts/piyush/healthy-thinking/how-has-covid-19-impacted-our-health
After: https://issue-41--sunstar--hlxsites.hlx.live/_drafts/piyush/healthy-thinking/how-has-covid-19-impacted-our-health
If you are adding a new block or a variation to an existing block, has it been added in the block-inventory ?